doom is now using the native api, add a PEB + TEB to replace the dummy and the awkward argument passing to processes, all allocations are zeroed because i had enough, small readme changes and dedication.

code/kernel/kmain.c

@@ -250,8 +250,8 @@ static PROCESS* LaunchUserProcess(const char* filePath, const char* args) {
     uint64_t size = IoGetFileSize(f);
     DbgPrint("LaunchUserProcess: IoGetFileSize: %llu\n", size);
 
-    void* mem = MmAllocateUserMemory(size);
-    DbgPrint("LaunchUserProcess: MmAllocateUserMemory: 0x%llX\n", mem);
+    void* mem = MmAllocatePool(size);
+    DbgPrint("LaunchUserProcess: MmAllocatePool: 0x%llX\n", mem);
     if (!mem) {
         IoCloseFile(f);
         return 0;
@@ -262,7 +262,7 @@ static PROCESS* LaunchUserProcess(const char* filePath, const char* args) {
     DbgPrint("LaunchUserProcess: IoReadFile: %d\n", s);
     IoCloseFile(f);
     if (!KSUCCESS(s)) {
-        MmFreeUserMemory(mem, size);
+        MmFreePool(mem);
         return 0;
     }
 
@@ -273,35 +273,23 @@ static PROCESS* LaunchUserProcess(const char* filePath, const char* args) {
     s = KeCreateProcess(filePath, &proc);
     if (!KSUCCESS(s)) {
         DbgPrint("Failed to create process. System halted.\n");
-        MmFreeUserMemory(mem, size);
+        MmFreePool(mem);
         return 0;
     }
-    DbgPrint("Created process (PID %u) with command line: %s\n", proc->ProcessId, filePath);
+    DbgPrint("Created process (PID %u) with command line: %s\n", proc->ProcessId, (args && args[0]) ? args : filePath);
 
-    if (args && args[0])
-        strncpy(proc->Cmdline, args, sizeof(proc->Cmdline) - 1);
-    else
-        strncpy(proc->Cmdline, filePath, sizeof(proc->Cmdline) - 1);
-    proc->Cmdline[sizeof(proc->Cmdline) - 1] = '\0';
-
-    // proc->Cmdline is kernel pool (ffffc000...) - not readable at CPL=3.
-    // Copy into user memory before handing the pointer to the initial thread.
-    size_t cmdlineLen = strlen(proc->Cmdline) + 1;
-    char* userCmdline = (char*)MmAllocateUserMemory(cmdlineLen);
-    if (!userCmdline) {
-        DbgPrint("LaunchUserProcess: Failed to allocate user cmdline buffer.\n");
-        MmFreeUserMemory(mem, size);
+    s = KeSetupUserProcessEnvironment(proc, filePath, args, proc->CurrentDirectory);
+    if (!KSUCCESS(s)) {
+        DbgPrint("LaunchUserProcess: Failed to build user process environment. Status: %d\n", s);
+        MmFreePool(mem);
         ObDereferenceObject(&proc->Header);
         return 0;
     }
-    memcpy(userCmdline, proc->Cmdline, cmdlineLen);
-    proc->UserCmdlineBase = (uintptr_t)userCmdline;
-    proc->UserCmdlineSize = cmdlineLen;
 
     // Parse the raw PE file and map it into executable memory.
     uintptr_t imageBase = 0;
     s = LdrLoadImage(mem, size, &imageBase, true);
-    MmFreeUserMemory(mem, size);
+    MmFreePool(mem);
     if (!KSUCCESS(s)) {
         DbgPrint("LaunchUserProcess: LdrLoadImage failed with status: %d\n", s);
         ObDereferenceObject(&proc->Header);
@@ -316,19 +304,22 @@ static PROCESS* LaunchUserProcess(const char* filePath, const char* args) {
         return 0;
     }
 
+    proc->ImageBase = imageBase;
+    proc->ImageSize = LdrGetImageSize(imageBase);
+
     uintptr_t entryPoint = LdrGetEntryPoint(imageBase);
     DbgPrint("LaunchUserProcess: PE Image mapped! Base 0x%llx, Entry 0x%llX\n", imageBase, entryPoint);
 
-    // Create the main thread, pointing it to the PE Entry Point.
-    s = KeCreateThread(proc, (uintptr_t)entryPoint, (uintptr_t)userCmdline, PriorityNormal, &thread);
+    // Create the main thread last. KeCreateThread queues it before returning.
+    s = KeCreateThread(proc, (uintptr_t)entryPoint, 0, PriorityNormal, &thread);
     if (!KSUCCESS(s)) {
         DbgPrint("LaunchUserProcess: Failed to create thread. Status: %d\n", s);
+        proc->ImageBase = 0;
+        proc->ImageSize = 0;
         MmFreeUserMemory((void*)imageBase, LdrGetImageSize(imageBase));
         ObDereferenceObject(&proc->Header);
         return 0;
     }
-    proc->ImageBase = imageBase;
-    proc->ImageSize = LdrGetImageSize(imageBase);
     DbgPrint("LaunchUserProcess: Thread created and queued!\n");
 
     // Caller owns the reference returned by KeCreateProcess.