clean up and standardize types across the codebase, unify atomic operations, improve UTF-8 handling throughout the system, remove obsolete input and named queue interfaces, redesign process preparation and creation, tighten IPC and service boundaries, improve error handling and reliability, minor documentation cleanup, fix doom surfaces, fix panic in ini parsing.

code/kernel/hal/hal_screen.c

@@ -26,12 +26,12 @@ static int       gCursorX = 0, gCursorY = 0;
 #include <kernel/hal/font8x16.h>   // see font8x16.h
 
 // Internals.
-static inline uint32_t* ScreenBackbufferPixel(int x, int y) {
+static inline uint32_t* ScreenBackbufferPixel(int32_t x, int32_t y) {
     return gBackbuffer ? (gBackbuffer + y * gStride + x) : (gFb + y * gStride + x);
 }
 
 // Updates pixel Raw.
-static inline void PutPixelRaw(int x, int y, uint32_t color) {
+static inline void PutPixelRaw(int32_t x, int32_t y, uint32_t color) {
     if ((unsigned)x >= (unsigned)gWidth || (unsigned)y >= (unsigned)gHeight)
         return;
 
@@ -60,26 +60,26 @@ static void ScreenFlushRows(int startY, int rows) {
 
 // HAL_SCREEN implementations.
 static void ScreenClear(uint32_t color) {
-    for (int y = 0; y < gHeight; y++)
-        for (int x = 0; x < gWidth; x++)
+    for (int32_t y = 0; y < gHeight; y++)
+        for (int32_t x = 0; x < gWidth; x++)
             ScreenBackbufferPixel(x, y)[0] = color;
     ScreenFlushRows(0, gHeight);
     if (!gBackbuffer) {
         // ScreenFlushRows is a no-op without a backbuffer.
-        for (int y = 0; y < gHeight; y++)
-            for (int x = 0; x < gWidth; x++)
+        for (int32_t y = 0; y < gHeight; y++)
+            for (int32_t x = 0; x < gWidth; x++)
                 gFb[y * gStride + x] = color;
     }
     gCursorX = 0; gCursorY = 0;
 }
 
 // Implements the screen Put Pixel operation.
-static void ScreenPutPixel(int x, int y, uint32_t color) {
+static void ScreenPutPixel(int32_t x, int32_t y, uint32_t color) {
     PutPixelRaw(x, y, color);
 }
 
 // Implements the screen Blit operation.
-static void ScreenBlit(int x, int y, int w, int h, const uint32_t* pixels) {
+static void ScreenBlit(int32_t x, int32_t y, int32_t w, int32_t h, const uint32_t* pixels) {
     // Calculate clipping bounds.
     int startX = (x < 0) ? 0 : x;
     int startY = (y < 0) ? 0 : y;
@@ -101,7 +101,7 @@ static void ScreenBlit(int x, int y, int w, int h, const uint32_t* pixels) {
     // Calculate bytes to copy per row.
     size_t bytesPerRow = (size_t)drawW * sizeof(uint32_t);
 
-    for (int row = 0; row < drawH; row++) {
+    for (int32_t row = 0; row < drawH; row++) {
         uint32_t* shadow = ScreenBackbufferPixel(startX, startY + row);
         uint32_t* fb = gFb + ((startY + row) * gStride) + startX;
         const uint32_t* src = pixels + ((srcOffsetY + row) * w) + srcOffsetX;
@@ -128,7 +128,7 @@ static KSTATUS ScreenGetFramebuffer(HAL_FRAMEBUFFER_INFO* outInfo) {
 }
 
 // Implements the screen Scroll operation.
-static void ScreenScroll(int lines) {
+static void ScreenScroll(int32_t lines) {
     if (lines <= 0)
         return;
     if (lines >= gHeight) {
@@ -145,8 +145,8 @@ static void ScreenScroll(int lines) {
     // Fill the revealed rows with the console background. Do not memset here:
     // the background color is not zero.
     uint32_t* fill = shadow + (gHeight - lines) * gStride;
-    for (int y = 0; y < lines; y++) {
-        for (int x = 0; x < gWidth; x++)
+    for (int32_t y = 0; y < lines; y++) {
+        for (int32_t x = 0; x < gWidth; x++)
             fill[y * gStride + x] = SCREEN_DEFAULT_BG;
     }
 
@@ -154,11 +154,11 @@ static void ScreenScroll(int lines) {
 }
 
 // Implements the screen Put Char operation.
-static void ScreenPutChar(char c, int x, int y, uint32_t fg, uint32_t bg) {
+static void ScreenPutChar(char c, int32_t x, int32_t y, uint32_t fg, uint32_t bg) {
     const uint8_t* glyph = Font8x16 + ((uint8_t)c * 16);
-    for (int row = 0; row < 16; row++) {
+    for (int32_t row = 0; row < 16; row++) {
         uint8_t bits = glyph[row];
-        for (int col = 0; col < 8; col++) {
+        for (int32_t col = 0; col < 8; col++) {
             uint32_t color = (bits & (0x80u >> col)) ? fg : bg;
             PutPixelRaw(x + col, y + row, color);
         }
@@ -234,10 +234,10 @@ static int      gCursorDrawX  = -1;   // -1 = cursor not yet drawn
 static int      gCursorDrawY  = -1;
 
 // Save the background rectangle [x,y,CURSOR_W,CURSOR_H] from the framebuffer.
-static void CursorSaveBg(int x, int y) {
-    for (int row = 0; row < CURSOR_H; row++) {
+static void CursorSaveBg(int32_t x, int32_t y) {
+    for (int32_t row = 0; row < CURSOR_H; row++) {
         int fy = y + row;
-        for (int col = 0; col < CURSOR_W; col++) {
+        for (int32_t col = 0; col < CURSOR_W; col++) {
             int fx = x + col;
             uint32_t px = 0;
             if ((unsigned)fx < (unsigned)gWidth && (unsigned)fy < (unsigned)gHeight)
@@ -248,10 +248,10 @@ static void CursorSaveBg(int x, int y) {
 }
 
 // Restore the background previously saved by CursorSaveBg.
-static void CursorRestoreBg(int x, int y) {
-    for (int row = 0; row < CURSOR_H; row++) {
+static void CursorRestoreBg(int32_t x, int32_t y) {
+    for (int32_t row = 0; row < CURSOR_H; row++) {
         int fy = y + row;
-        for (int col = 0; col < CURSOR_W; col++) {
+        for (int32_t col = 0; col < CURSOR_W; col++) {
             int fx = x + col;
             if ((unsigned)fx < (unsigned)gWidth && (unsigned)fy < (unsigned)gHeight) {
                 uint32_t px = gBackbuffer
@@ -287,13 +287,13 @@ static inline uint32_t BlendPixel(uint32_t dst, uint32_t src) {
 
 // Draw the arrow sprite at (x,y), saving the background first.
 // Called from hal_mouse.c via extern declaration.
-void HalScreenDrawCursor(int x, int y) {
+void HalScreenDrawCursor(int32_t x, int32_t y) {
     CursorSaveBg(x, y);
     gCursorDrawX = x;
     gCursorDrawY = y;
-    for (int row = 0; row < CURSOR_H; row++) {
+    for (int32_t row = 0; row < CURSOR_H; row++) {
         int fy = y + row;
-        for (int col = 0; col < CURSOR_W; col++) {
+        for (int32_t col = 0; col < CURSOR_W; col++) {
             uint32_t src = gCursorPixels[row][col];
             if ((src >> 24) == 0) continue; // fully transparent, skip
             int fx = x + col;
@@ -341,7 +341,7 @@ void HalScreenRegisterOutputEndpoint(HAL_OUTPUT_ROUTER* output) {
 }
 
 // Populate the HAL_SCREEN vtable.
-void HalScreenInitialize(void* (*AllocatePool)(size_t size), uintptr_t fb, int w, int h, int stride,
+void HalScreenInitialize(void* (*AllocatePool)(size_t size), uintptr_t fb, int32_t w, int32_t h, int32_t stride,
                         HAL_SCREEN* out) {
     gFb     = (uint32_t*)fb;
     gWidth  = w;