replace the VHD/diskpart disk image pipeline with a directory-based vvfat root, we'll see when it breaks, fix /O2, add an all_tests, generalize the fat32 driver into a fat 16+32 driver, change policy on volume drivers, collapse KCPU's fields into a single atomic KE_CPU_STATE state machine, move scheduler ticking to per-CPU LAPIC timers, gate verbose SMP topology logging behind selftest diagnostics and add SMP pool-checkpoint validation around AP admission, add checked intrusive list helpers behind a new KE_DEBUG_LIST_CHECKS flag, add ObInitializeObjectHeader/ObTryReferenceObject, add waitable display clock objects and a SYS_OPEN_DISPLAY_CLOCK syscall for vsync-style waits, refactor kernel input into a per-queue KE_INPUT_CONTEXT with its own key/mouse ring buffers and DPC-driven key repeat, add KeInputQueuePeekEvent/ReadEvent/WaitKey and a SYS_QUERY_GLOBAL_INPUT_STATE syscall, split the kernel pool allocator out of mm_virt, new video files!

code/kernel/ke_thread.c

@@ -1,6 +1,7 @@
 // Thread manager. This file owns thread allocation, kernel/user startup contexts, and lifecycle transitions.
 
 #include <string.h>
+#include <kernel/ke_list.h>
 #include <stddef.h>
 #include <intrin.h>
 #include <kernel/ke_thread.h>
@@ -26,10 +27,10 @@
     _Static_assert(offsetof(type, field) == (expected), \
                    #type "." #field " offset must match assembly")
 
-STATIC_ASSERT_OFFSET(THREAD, SavedContext, 88);
-STATIC_ASSERT_OFFSET(THREAD, TssRsp0, 104);
-STATIC_ASSERT_OFFSET(THREAD, Teb, 112);
-STATIC_ASSERT_OFFSET(THREAD, FpuContext, 168);
+STATIC_ASSERT_OFFSET(THREAD, SavedContext, 96);
+STATIC_ASSERT_OFFSET(THREAD, TssRsp0, 112);
+STATIC_ASSERT_OFFSET(THREAD, Teb, 120);
+STATIC_ASSERT_OFFSET(THREAD, FpuContext, 176);
 
 static uint32_t gNextThreadId = 1;
 extern void KeThreadEntry(void);
@@ -68,7 +69,7 @@ static void KiThreadDestroy(OBJECT* obj) {
         PROCESS* owner = thread->Owner;
         uint32_t remaining = 0;
         uintptr_t flags = KeAcquireSpinlock(&owner->HandleLock);
-        ListRemove(&thread->ProcessLink);
+        KeListRemoveChecked(&thread->ProcessLink);
         if (owner->ThreadCount) owner->ThreadCount--;
         remaining = owner->ThreadCount;
         KeReleaseSpinlock(&owner->HandleLock, flags);
@@ -138,7 +139,7 @@ __declspec(dllexport) KSTATUS KeCreateThread(PROCESS* owner, uintptr_t entry, ui
     }
     memset(kstack, 0, KSTACK_SIZE);
     thread->KernelStackBase = kstack;
-    thread->KernelStackTop  = (uintptr_t)kstack + KSTACK_SIZE;
+    thread->KernelStackTop  = ((uintptr_t)kstack + KSTACK_SIZE) & ~(uintptr_t)15;
     thread->TssRsp0         = thread->KernelStackTop;
 
     KSTATUS s;
@@ -230,7 +231,7 @@ __declspec(dllexport) KSTATUS KeCreateThread(PROCESS* owner, uintptr_t entry, ui
     thread->ExitEvent = exitEvent;
 
     uintptr_t flags = KeAcquireSpinlock(&owner->HandleLock);
-    ListInsertTail(&owner->ThreadList, &thread->ProcessLink);
+    KeListInsertTailChecked(&owner->ThreadList, &thread->ProcessLink);
     owner->ThreadCount++;
     KeReleaseSpinlock(&owner->HandleLock, flags);
 
@@ -335,7 +336,7 @@ static KSTATUS KiCreateKernelThreadWithAffinity(uintptr_t fn, uintptr_t arg,
     }
     memset(kstack, 0, KSTACK_SIZE);
     thread->KernelStackBase = kstack;
-    thread->KernelStackTop  = (uintptr_t)kstack + KSTACK_SIZE;
+    thread->KernelStackTop  = ((uintptr_t)kstack + KSTACK_SIZE) & ~(uintptr_t)15;
     thread->TssRsp0         = thread->KernelStackTop;
 
     // Build the initial stack: arg, fn, then KCONTEXT.
@@ -354,7 +355,7 @@ static KSTATUS KiCreateKernelThreadWithAffinity(uintptr_t fn, uintptr_t arg,
     thread->Owner = owner;
 
     uintptr_t flags = KeAcquireSpinlock(&owner->HandleLock);
-    ListInsertTail(&owner->ThreadList, &thread->ProcessLink);
+    KeListInsertTailChecked(&owner->ThreadList, &thread->ProcessLink);
     owner->ThreadCount++;
     KeReleaseSpinlock(&owner->HandleLock, flags);
 
@@ -471,7 +472,7 @@ KSTATUS KeCommitBlockThread(THREAD* thread, uint8_t alertable) {
     // consume the alertable wait immediately instead of going to sleep.
     if (alertable && thread->UserApcPending && thread->UserApcDispatcher) {
         if (thread->WaitListHead)
-            ListRemove(&thread->SchedulerLink);
+            KeListRemoveChecked(&thread->SchedulerLink);
         KiFinishWait(thread, NTLSTATUS_USER_APC);
         thread->State = ThreadRunning;
         return NTLSTATUS_USER_APC;
@@ -522,7 +523,7 @@ static int KiRemoveThreadFromObjectWaitListLocked(THREAD* thread, LIST_ENTRY* wa
     if (!KiThreadWaitLinkIsLinked(thread))
         return 0;
 
-    ListRemove(&thread->SchedulerLink);
+    KeListRemoveChecked(&thread->SchedulerLink);
     thread->WaitListHead = (LIST_ENTRY*)0;
     thread->SleepUntilTick = 0;
     thread->TimeoutStatus = NTLSTATUS_SUCCESS;
@@ -601,7 +602,7 @@ static KSTATUS KiAlertThreadWithStatus(THREAD* thread, KSTATUS status) {
         return NTLSTATUS_PENDING;
 
     if (thread->WaitListHead)
-        ListRemove(&thread->SchedulerLink);
+        KeListRemoveChecked(&thread->SchedulerLink);
 
     KeUnblockThreadWithStatus(thread, status);
     return NTLSTATUS_SUCCESS;